New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output JUnit XML test metadata for CircleCI #11949
Comments
I would like to work on this issue! (this will be my first contribution) |
@benbraou, it's yours! |
I am working on this issue this weekend |
Overview of changesI will be updating this comment as subtasks of this issue get implemented. Subtasks
|
@sophiebits I would like to check with you my proposal for Flow JUnit report generation before I start the implementation. Flow only supports JSON output.
That transformer could also be used to generate reports based on the return of the other build scripts ( upload_build.sh, test_print_warnings ...) What do you think ? |
I think for flow it is fine to treat it as a single "test" that has a single output and just use the formatted output. Not sure if there is much advantage to try to split flow into multiple "tests". |
I see. Thank you! |
A pull request has been submitted #12023 SummaryCurrently, when the build fails, there is no way to know what happened other than going through the logs in CircleCI. The goal of this PR is to output JUnit XML metadata for every build step. This allows CircleCI summary page to display exactly which step has failed. What this PR does:
|
May I work on it? Can someone help me? |
@bvaughn @sophiebits is it okay if I pick this up? Just starting out (first open source issue) |
Hello @sophiebits , I'm here first time. Can I work on this ? |
Hello @sophiebits! Can I work on this? |
Hi @sophiebits please let me know if the issue still exists? I would like to get working |
We're moving off of CircleCI, so this no longer applies. Maybe there's something similar on GitHub Actions that would make sense, I don't know. |
@benbraou has claimed this issue. Please give them a chance to work on this.
Here's a screenshot of a CircleCI build for another (private) project I'm a part of:
It clearly highlights the parts of the build that failed.
In contrast, see one of our builds: https://circleci.com/gh/facebook/react/8402. In this one the ./scripts/circleci/upload_build.sh step failed but you need to scroll through the output a significant amount to see that. This is in part because we have a custom entry point for all our CI steps (scripts/circleci/test_entry_point.sh) to make it easier for us to parallelize some build steps.
I'd like us to change that test_entry_point.sh script to output JUnit XML metadata for CircleCI as described in https://circleci.com/docs/2.0/collect-test-data/. Then I believe the CircleCI build results page will show exactly which step failed.
(Bonus: If we can show individual Jest tests that would be even cooler. But I think the most important part is breaking out jest vs flow vs prettier, etc. into separate chunks.)
The text was updated successfully, but these errors were encountered: