Redux DevTools issue for reference/inspiration/impact: reduxjs/redux-devtools#1037

Hey! Thanks so much for the heads up! We've added it to our plans for this year. 😊

@lunaruan I would love to work on this issue. Kindly assign this issue to me.

Hey, sure you can take a stab at it!

@DhairyaBahl that would be nice! When do you plan to start working on it?

To my knowledge, the last time we investigated manifest v3 – there were blockers for our adopting it. I think maybe the run_at option was missing the "document_start" maybe but I'm not sure?

@mondaychen I will start exploring this issue soon. Since I am a new contributor to React, successful PR may take some time. If this issue needs to be resolved on urgent basis then do let me know.

@bvaughn haven't tested but at least it's still in the V3 docs https://developer.chrome.com/docs/extensions/mv3/content_scripts/#run_time

@DhairyaBahl there's a timeline for the migration: https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
We don't want to wait until last minute... I think for now we hope to get it done by September. That's plenty of time if you are starting now.
You can follow the README under the extension package folder to get started. Let me know if you need help!

reduxjs/redux-devtools#1037

@lunaruan @gaearon Can you assign this to me please?

@Hanaffi sure :)

@lunaruan Actually I was working on this issue. 🥲

@DhairyaBahl Oh no sorry! We thought you weren't because we hadn't heard from you in awhile (sorry people drop out a lot in OSS!). I'll assign this to you instead 😊

Do you know when you'd get around to it, just so we know when to reassign this if needed?

Do you know when you'd get around to it, just so we know when to reassign this if needed?

Actually @lunaruan I was going through this issue and 've been reading the contributor docs and lots of other docs just to have bit more clarity on this issue coz I am contributing to React for the first time. So, it may take a while before I can make a PR but 'll try to make a PR within a week or two. Hope you understand.

Thanks 🙂

@DhairyaBahl That works for us! Thanks so much for volunteering to help out!

@lunaruan @mondaychen I am facing problem in building react in Windows. Everything is working perfectly in Linux but even the yarn command is not working on windows and is showing this error.

Kindly help me out with this one.

Thanks 🙂

@DhairyaBahl are you working on Windows because you no longer have access to your Linux machine? Just wanna make sure because you only need to build it on one OS.
Which yarn command was this?

sorry, hanaffi was not active, I submitted the PR. Hope no one is angry as It's my first contribution. @mondaychen

Hi all,
We originally mark this as a "good first issue" as it does not require deep understanding of react or react devtools. So far, we have not seen a mature PR on this issue. As the deadline is fast approaching, we decided we need to get it done soon. If you have something that's almost done, please let me know. Otherwise, please consider this project is taken by a react team member.

@mondaychen Hi Mondy,
I agree its a good first issue as I understood everything that needs to be done.

But there is an issue here that im trying to solve which isnt directly related to the manifest upgrade.

Firstly in order to test the changes you need to build the extension locally. Although there is a readme in the package extension rep. , there are still several issues when building the extension locally which I already opened issues for, and 1 got accepted and they changed the readme for, but there arw still more.

If you want I can give you an exact timeline tomorrow as I would like to work on it, but the extension repo is giving me a lot of problems currently.

@SijaanX
I agree there's room for improvements in our documentation, and thank you for contributing by creating issues about it.
If you (or anyone else) have more questions regarding how to set up the development environment, build & test the extension, you can ask here or in another issue, and I'd like to offer help.
As for this project, I hope you understand it's actually much more work for team members to guide external contributors to get things done than to get it done ourselves. It's also very unpredictable -- you can see this project was assigned to several different people, and now we are still nowhere near any real progress. For a project with a hard deadline, it's safer for us to assign a teammate to it.

@mondaychen I understand you completely and its not a good sign when people just get busy and don't give a notice, and when stuck don't try to get help (which will definitely help a lot of others).
Anyway, I'm building it now locally again, and I will make sure to list all of the issues I face for future contributors.
Again I will completely understand if you give it to a team member, as migration deadline is the start of 2023 which is around the corner.

I will do my best now to try and do the upgrade locally. It would be nice if I succeed anyway :D

@mondaychen Issues:

#1: When building the extension locally, you have to run: yarn build-for-devtools from the root repository.

This results in the following:

'cp' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.

I guess the solution to this is to change cp to copy as I'm using windows?

@SijaanX if you are having issues with basic bash commands like cp you will encounter the same issue with other commands too. I don’t have a lot of experience developing on Windows, but to my knowledge you probably need to set up a Linux-like command line environment such as WSL https://docs.microsoft.com/en-us/windows/wsl/setup/environment

@mondaychen Managed to solve it as I used xcopy with the recursive flags.

is this error:

injectGlobalHook.js:2132 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'wasm-unsafe-eval'". Either the 'unsafe-inline' keyword, a hash ('sha256-jmNafx23y91B5KUD5ahB8ex4/ewYkOS39Bl4Yk3Mweg='), or a nonce ('nonce-...') is required to enable inline execution.

injectCode @ injectGlobalHook.js:2132
page-data.json:1          Failed to load resource: the server responded with a status of 404 ()

related to the fact that I have to change the XMLHttpRequest to fetch() or is it something else?

This is the relevant part from the manifest.json:

  "content_security_policy": {
    "extension_pages": "script-src 'self'; object-src 'self'"
  },

Yes, looks like we'll need to either use a different policy or change how we implement injectCode

I'm almost done with the updates but I'm not able to test the extension, even though I followed the readme file. any suggestions are highly appreciated. thank you

@AnmolBansalDEV Can you describe the issue you are having? Which step did you get stuck with?

@mondaychen I managed to change how we inject the code.
Now I'm getting stuck on something else, where I have no idea where to debug it from:

Any idea?

@SijaanX can you push your code somewhere? I'll take a look

@SijaanX I have a Windows machine and I have git installed so I use the git bash terminal and I don't have to change any of the commands to build.

@mondaychen It's been a couple weeks since the Manifest V3 update was added. What is the timeframe for getting the updated extension into the Chrome webstore?

@pomack we've released it to some users within Meta. If nothing goes wrong in the following a few weeks, we will release it to Chrome Web Store

There are still warnings when using React Devtools with the latest Electron (v22):

┏ Electron -------------------

  (node:50201) ExtensionLoadWarning: Warnings loading extension at /Users/bartel/git/klstr-ctrl/node_modules/electron-devtools-vendor/extensions/react-developer-tools:
    Permission '<all_urls>' is unknown or URL pattern is malformed.
  
  (Use `Electron --trace-warnings ...` to show where the warning was created)

┗ ----------------------------

And:

┏ Electron -------------------

  [50201:1206/093424.883640:ERROR:extensions_browser_client.cc(62)] Extension Error:
    OTR:     false
    Level:   2
    Source:  chrome-extension://dmcmnlnmbgdfljfjniabngbfglcgggdk/build/background.js
    Message: Uncaught TypeError: Cannot read properties of undefined (reading 'registerContentScripts')
    ID:      dmcmnlnmbgdfljfjniabngbfglcgggdk
    Type:    RuntimeError
    Context: chrome-extension://dmcmnlnmbgdfljfjniabngbfglcgggdk/build/background.js
    Stack Trace: 
      {
        Line:     107
        Column:   1
        URL:      chrome-extension://dmcmnlnmbgdfljfjniabngbfglcgggdk/build/background.js
        Function: (anonymous function)
      }

┗ ----------------------------
┏ Electron -------------------

  [50201:1206/093424.884128:ERROR:extensions_browser_client.cc(62)] Extension Error:
    OTR:     false
    Level:   1
    Source:  manifest.json
    Message: Service worker registration failed. Status code: 15
    ID:      dmcmnlnmbgdfljfjniabngbfglcgggdk
    Type:    ManifestError

┗ ----------------------------

Somehow the ID is messed up, I don't know what electron (or my electron install provider) does with this, but it's definitely the React Devtools:

node_modules//electron-devtools-vendor/extensions/react-developer-tools/build/background.js:107: chrome.scripting.registerContentScripts([{

Apparently, this is a Electron issue (only): electron/electron#36545

But, isn't the "scripting" permission needed for accessing chrome.scripting?
As explained here: https://developer.chrome.com/docs/extensions/reference/scripting/#manifest ?

EDIT: Oh, I see it was changed recently, 4b09b0a, but it's not released like this yet...

That's still happening for me :c is there any solution or workaround for this issue?