Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pod warning if pod had oomkill and memory limit is set #4601

Open
jakolehm opened this issue Dec 22, 2021 · 2 comments
Open

Show pod warning if pod had oomkill and memory limit is set #4601

jakolehm opened this issue Dec 22, 2021 · 2 comments
Labels
area/ui enhancement New feature or request good first issue Good for newcomers

Comments

@jakolehm
Copy link
Contributor

What would you like to be added:

Lens should show a warning icon if pod has been previously oomkilled and it has memory limit set.

Why is this needed:

Easier to spot misconfigurations.
@jakolehm jakolehm added enhancement New feature or request area/ui labels Dec 22, 2021
@jakolehm jakolehm added this to the 5.5.0 milestone Dec 22, 2021
@Nokel81 Nokel81 added the good first issue Good for newcomers label Mar 8, 2022
@Nokel81 Nokel81 removed this from the 5.5.0 milestone Mar 8, 2022
@samceena
Copy link

samceena commented Jun 2, 2022 •
edited

can you pls explain what this issue is?
I also noticed when a POD crashes due to OOM, there's a warning icon in the pod details view.
Are you referring to something else?

@jakolehm
Copy link
Contributor Author

jakolehm commented Jun 2, 2022

@samceena currently the warning icon disappears pretty soon after a pod is running without issues. This hides the fact that pod got oomkill and probably will have similar issue in the future. I would like to see a warning that nags until some action has been taken (like modifying a memory limit or some other config change).

See

lens/extensions/kube-object-event-status/src/resolver.tsx

Line 34 in b86d409

if (!pod.hasIssues()) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakolehm @samceena @Nokel81