Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Store sql in current execution context for better debugging. #2777

Closed
liurenjie1024 opened this issue May 24, 2022 · 2 comments · Fixed by #3312
Closed

frontend: Store sql in current execution context for better debugging. #2777

liurenjie1024 opened this issue May 24, 2022 · 2 comments · Fixed by #3312
Labels
component/frontend Protocol, parsing, binder. good first issue Good for newcomers type/enhancement Improvements to existing implementation.

Comments

@liurenjie1024
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently after parsing, our raw sql is discarded. This make printing debugging information including sql impossible.

Describe the solution you'd like

Store raw sql, in current execution context or session to so that following debugging will be easier.

Describe alternatives you've considered

No.

Additional context
No.
@liurenjie1024 liurenjie1024 added type/enhancement Improvements to existing implementation. good first issue Good for newcomers component/frontend Protocol, parsing, binder. labels May 24, 2022
@nhzaci
Copy link
Contributor

nhzaci commented Jun 11, 2022

Hi, I would like to take this on, are there some useful places for me to start digging into to get into this task?

@lmatz
Copy link
Contributor

lmatz commented Jun 11, 2022 •
edited

Hi, I would like to take this on, are there some useful places for me to start digging into to get into this task?

https://github.com/singularity-data/risingwave/blob/main/src/frontend/src/handler/query.rs#L151
could be a starting point.

@nhzaci nhzaci mentioned this issue Jun 18, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/frontend Protocol, parsing, binder. good first issue Good for newcomers type/enhancement Improvements to existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(frontend): Add sql string into context for debugging nhzaci/risingwave
3 participants
@liurenjie1024 @lmatz @nhzaci