Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change learner action to be a welcome message on new pull requests #6

Merged
merged 8 commits into from Jun 8, 2022
Merged

Conversation

heiskr
Copy link
Contributor

@heiskr heiskr commented Jun 8, 2022

Why:

Closes #3

What's being changed:

Updates course to make a welcome message instead of an emoji check.

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link

@rsese rsese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned through the workflow changes and they looked fine but went ahead and cloned your fork and ran through the updated course with no problem 👍 !

@heiskr heiskr merged commit 47c4d8a into skills:main Jun 8, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

#6

sinsukehlab added a commit to sinsukehlab/hello-github-actions that referenced this pull request Oct 3, 2022
sinsukehlab added a commit to sinsukehlab/hello-github-actions that referenced this pull request Oct 3, 2022
Revert "Change learner action to be a welcome message on new pull requests (skills#6)"
sinsukehlab added a commit to sinsukehlab/hello-github-actions that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change learner action to be a welcome message on new pull requests
2 participants