feat: add addition override parameters #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-it
commented
May 21, 2021
| process.env.COVERALLS_GIT_BRANCH = gitBranch; | ||
| } | ||
|
|
||
| if (process.env.GITHUB_EVENT_NAME == 'pull_request' || process.env.GITHUB_EVENT_NAME == 'pull_request_target') { |
There was a problem hiding this comment.
Both pull_request and pull_request_trigger contain this information. However I did not want to add explicit support for pull_request_trigger in the docs as this might confuse users.
There was a problem hiding this comment.
@mad-it We just stumbled over, that using pull_request_target does not work out of the box with coveralls.
As I know now, we need to provide git-commit as a parameter to the step.
I would suggest to mention this in the documentation, because I think with the switch to native-dependabot some other people will also stumble over this problem.
|
Thank you @mad-it! |
eyal0
pushed a commit
to eyal0/github-action
that referenced
this pull request
Dec 8, 2022
eyal0
pushed a commit
to eyal0/github-action
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to override both the commit and the branch name if they wish to do so.
In our use-case this allows us to use
pull_request_targetas a trigger for GH actions.