Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips broken on Android #4924

Open
1 of 7 tasks
Dakror opened this issue Oct 12, 2017 · 6 comments
Open
1 of 7 tasks

Tooltips broken on Android #4924

Dakror opened this issue Oct 12, 2017 · 6 comments
Labels
android good first issue help wanted Indicates further help on this issue or PR is needed scene2d

Comments

@Dakror
Copy link

Dakror commented Oct 12, 2017

Issue details

Tooltips broken on Android. They do not show but cause an exception instead.
Also referenced in #4921

Reproduction steps/code

Run the UITest on android (i used a Huawei P8, Android 5)

Version of LibGDX and/or relevant dependencies

1.9.6

Stacktrace

10-12 18:23:17.610 571-761/com.badlogic.gdx.tests.android W/System.err: java.lang.NullPointerException: Attempt to invoke virtual method 'com.badlogic.gdx.scenes.scene2d.Stage com.badlogic.gdx.scenes.scene2d.Actor.getStage()' on a null object reference
10-12 18:23:17.610 571-761/com.badlogic.gdx.tests.android W/System.err:     at com.badlogic.gdx.scenes.scene2d.ui.TooltipManager$2.run(TooltipManager.java:69)
10-12 18:23:17.610 571-761/com.badlogic.gdx.tests.android W/System.err:     at com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame(AndroidGraphics.java:488)
10-12 18:23:17.610 571-761/com.badlogic.gdx.tests.android W/System.err:     at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1531)
10-12 18:23:17.610 571-761/com.badlogic.gdx.tests.android W/System.err:     at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1248)

Please select the affected platforms

  • Android
  • iOS (robovm)
  • iOS (MOE)
  • HTML/GWT
  • Windows
  • Linux
  • MacOS
@Dakror Dakror mentioned this issue Oct 12, 2017
Closed
@Tom-Ski
Copy link
Member

Tom-Ski commented Oct 25, 2017 •
edited

I can't reproduce this on my device. You are running the stock UITest, what are the exact steps to reproduce? What are you hovering over etc?

@Dakror
Copy link
Author

Dakror commented Oct 25, 2017 •
edited

I'm running the stock UITest and when tapping on the Button "Multi Line Toggle" there should be a tooltip popping up, but instead an exception gets thrown. As stated in the PR, using a real Android phone for this.

@Tom-Ski
Copy link
Member

Tom-Ski commented Oct 26, 2017

Yeah, I can't reproduce this with your steps. I'll try find another device to test on to see if i can it there. Otherwise, hopefully someone else can reproduce and test.

@Tom-Ski Tom-Ski added good first issue help wanted Indicates further help on this issue or PR is needed labels Nov 1, 2017
@Zomby2D
Copy link
Contributor

Zomby2D commented Nov 23, 2017 •
edited

I tried various phones and tablets with Android versions ranging from 4.1.2 to 7.1, and I can't reproduce the issue either. The tooltip always pops up correctly for me. (I tried with both USB and Bluetooth mices)

Are there any other steps I might be missing here?

@Dakror
Copy link
Author

Dakror commented Nov 23, 2017 •
edited

No there are no other steps involved. I sadly do not have any other working phone around to pin point the issue to my device specifically. Huawei is involved in all kinds of weird Android bugs though.

Using the Huawei P8 for this.

@mobiuscog
Copy link

It's likely a race condition as TooltipManager isn't thread-safe - there are no synchronization / guard blocks.

@libgdx libgdx deleted a comment from tookjacksuio Jan 11, 2022
@libgdx libgdx deleted a comment from tookjacksuio Jan 11, 2022
@libgdx libgdx deleted a comment from tookjacksuio Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android good first issue help wanted Indicates further help on this issue or PR is needed scene2d
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mobiuscog @Dakror @Tom-Ski @Zomby2D @MrStahlfelge and others