Add Netlify integration for DOM Fixtures folder #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. This is so cool; thank you so much!! Let's get the account stuff setup! |
|
awesome! |
|
Any chance I can get an update on the status of this? |
|
@klamping Hey sorry for no response, we're pretty swamped by some longer term projects and so everything related to infra like testing is on a backburner. We really appreciate the PR but realistically we don't have enough time to review DOM-related changes either so it's not urgent to get in. When we get closer to working on these changes, we'll definitely check it out. Thanks! |
|
@gaearon thanks for getting back with me and the explanation on it all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #11079, @nhunzaker mentions that it would be nice to have an automatic deployment of the DOM Fixtures folder for manual and automated testing purposes.
Since Netlify offers their services for free to open source projects (an account for this will need to be set up), I thought it would be a great fit.
This commit adds a
netlify.tomlfile to the repo, allowing easier deployment out to the service.This file will do two things:
The preview site is linked via GitHub in the PR.
Test Plan:
Create a Netlify account and connect the github repo you're testing to it.
After connection, Netlify should deploy the DOM fixtures build folder to a live site for you to use.