Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a Channel of type tcpip-forward is closed, it does not emit the closure request #16

Open
Joannis opened this issue May 8, 2020 · 1 comment
Open

When a Channel of type tcpip-forward is closed, it does not emit the closure request #16

Joannis opened this issue May 8, 2020 · 1 comment

Comments

@Joannis
Copy link
Collaborator

Joannis commented May 8, 2020

I'd suggest the channel to keep track of the channel being explicitly closed by the user or third party. When it is explicitly closed, I'd send the "cancel-tcpip-forward" global request as described on RFC 4254 page 17. This way, the user does not need to concern itself with protocol specific knowledge. This allows libraries to wrap a channel without requiring awareness of the SSH protocol.
@Lukasa
Copy link
Collaborator

Lukasa commented May 8, 2020

tcpip-forward is one connection, but there may be many when doing reverse port forwarding. We only know when to send cancel when the server channel is closed, and we didn’t create it so we don’t know when it goes away.

We can provide a default delegate that handles this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lukasa @Joannis