WriteThread::EnterAsBatchGroupLeader reorder writers #12138
Conversation
mm304321141
force-pushed
the
reorder-writes
branch
from
5da05e2
to
fc8c5df
Compare
|
@siying @ajkr @igorcanadi @riversand963 @IslamAbdelRahman @maysamyabandeh |
db/write_thread.cc
Outdated
| // @leader, n1, *n2, n3, *newest_writer | ||
| // @leader, *n2, n3, *newest_writer, n1 | ||
| // @leader, @n2, n3, *newest_writer, n1 | ||
| // @leader, @n2, @newest_writer, n1, n3 | ||
| // case A | ||
| // @leader, @n2, @newest_writer, n1, n3 | ||
| // case B | ||
| // @leader, @n2, @newest_writer, n4 n1, n3 | ||
| // @leader, @n2, @newest_writer, n1, n3, n4 |
There was a problem hiding this comment.
Could you please describe the notation above the comment?
My understanding is
- Each line before the "case"s is the state at the beginning of an iteration of the while-loop
- Each "case" is a possible state at the end of the function
- Items prefixed by
@have been included inwrite_group - Items prefixed by
*share the same options aswrite_group, but have not been included yet - Items after several spaces are in
r_list, temporarily separated from the main list
There was a problem hiding this comment.
Done. Let me know if you disagree with any of the changes I made.
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mm304321141 has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mm304321141 has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Reorder writers list to allow a leader can take as more commits as possible to maximize the throughput of the system and reduce IOPS.