Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and Fix JavaDoc issues in RocksJava #12149

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Cleanup and Fix JavaDoc issues in RocksJava #12149

wants to merge 14 commits into from

Conversation

adamretter
Copy link
Collaborator

@adamretter adamretter commented Dec 14, 2023 •
edited

  • Fixed problems with existing JavaDoc.
  • Added missing JavaDoc.
  • Make JavaDoc warnings report as an error.
  • Add a CI job to ensure that JavaDoc is always present and correct in future.

In total this resolves over 400 JavaDoc warnings/errors.

@adamretter adamretter force-pushed the eb/cleanup-native-handle branch 2 times, most recently from 71c80cc to 0efb705 Compare December 21, 2023 20:53
@adamretter adamretter marked this pull request as ready for review December 21, 2023 20:56
@adamretter adamretter force-pushed the eb/cleanup-native-handle branch 8 times, most recently from 80632b6 to ea76e36 Compare December 21, 2023 23:39
@ajkr
Copy link
Contributor

ajkr commented Feb 20, 2024 

src/main/java/org/rocksdb/util/StdErrLogger.java:15: error: StdErrLogger is not abstract and does not override abstract method getNativeHandle() in LoggerInterface
public class StdErrLogger extends RocksObject implements LoggerInterface {
       ^
src/main/java/org/rocksdb/RocksDB.java:3945: warning: [deprecation] OUT_OF_BOUNDS in PerfLevel has been deprecated
    } else if (level == PerfLevel.OUT_OF_BOUNDS) {
                                 ^
1 error
1 warning

(https://github.com/facebook/rocksdb/actions/runs/7807589234/job/21296253965?pr=12149)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdillinger pdillinger Awaiting requested review from pdillinger

@ajkr ajkr Awaiting requested review from ajkr

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamretter @ajkr @facebook-github-bot