Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snappy dependency for Java releases. #12207

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update snappy dependency for Java releases. #12207

wants to merge 2 commits into from

Conversation

rhubner
Copy link
Contributor

@rhubner rhubner commented Jan 5, 2024 •
edited

BLOCKED
Current version of snappy doesn't compile on MacOS.

@adamretter adamretter self-requested a review January 5, 2024 12:57
@rhubner rhubner force-pushed the eb/snappy-update branch 2 times, most recently from dfe14c1 to 3afbf1b Compare February 7, 2024 12:25
@pdillinger
Copy link
Contributor

Super weird to see the warnings as error in Snappy because

cd snappy-1.1.10/build && CFLAGS='-arch x86_64  ' CXXFLAGS='-arch x86_64  ' LDFLAGS=' ' cmake -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DSNAPPY_BUILD_BENCHMARKS=OFF -DSNAPPY_BUILD_TESTS=OFF --compile-no-warning-as-error  .. && /Applications/Xcode_14.3.1.app/Contents/Developer/usr/bin/make 
                                                                                                                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamretter adamretter Awaiting requested review from adamretter

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhubner @pdillinger @facebook-github-bot