IsEmpty() checks were missing before some SwitchMemtable() invocations #12230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, causing empty memtable creation.
ajkr
requested changes
Jan 13, 2024
There was a problem hiding this comment.
A relevant test "DBTest.DeletingOldWalAfterDrop" fails. It is likely that empty memtables can pin old WALs, which we would need to somehow fix first.
By the way, empty memtable is supposed to be cheap (minimal memory usage), at least for inline skiplist. If it's consuming meaningful memory, we might be doing something wrong there.
|
This PR did not fix the issue, we applied this PR to our branch, the issue still exists: The gray text is empty MemTable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12179
There was one instance where the IsEmpty() check was missing:
rocksdb/db/db_impl/db_impl_write.cc
Line 1706 in 21d5a8f
Having one check inside SwitchMemTable() will ensure there won't be misses in the future.