Export rocksdb fuctions in rocksdbjni.dll #12246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhubner
force-pushed
the
eb/rocksjni-export-fuctions
branch
3 times, most recently
from
24960c9
to
23e4564
Compare
rhubner
force-pushed
the
eb/rocksjni-export-fuctions
branch
from
23e4564
to
9d50374
Compare
rhubner
force-pushed
the
eb/rocksjni-export-fuctions
branch
from
451216d
to
33b8098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the CMake build process on Windows to export all RocksDB functions in
rocksdbjni.dll.This allows us to reuse Java builds artifacts in other programming languages without need to manually recompile the .dll for each language.
Closes #12226