Refactor external sst file ingestion job #12305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlyzhang
force-pushed
the
bulk_loading
branch
from
f0f1438
to
edf1d41
Compare
jowlyzhang
force-pushed
the
bulk_loading
branch
from
edf1d41
to
9b62dfd
Compare
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jowlyzhang merged this pull request in 4eaa771. |
cbi42
reviewed
Feb 5, 2024
| f.internal_file_path.c_str(), s.ToString().c_str()); | ||
| } | ||
| } | ||
| DeleteInternalFiles(); |
There was a problem hiding this comment.
It seems we call Cleanup() after Prepare() return non-ok status:
Line 5850 in 6e88126
There was a problem hiding this comment.
Yes, do you mean that we should remove this DeleteInternalFiles call from Prepare, so we don't get the "clean up for file failed" for this scenario?
There was a problem hiding this comment.
Yeah, I did not think about the warnings but just that we don't need to call DeleteInternalFiles() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates some documentations and invariant assertions after #12257 and #12284. Also refactored some duplicate code and improved some error message and preconditions for errors.
Test plan:
Existing unit tests