Added calc module with regards to #88 #92
Conversation
modules/calc.js
Outdated
| try { | ||
| client.sendMessage( | ||
| BotsApp.chatId, | ||
| `output: ${output}`, |
There was a problem hiding this comment.
Use the argument itself instead of "output". e.g. 5+2 = 7
modules/calc.js
Outdated
| output = math.evaluate(args[0]); | ||
| } | ||
| catch(err){ | ||
| await inputSanitization.invalidFormat(err, client, BotsApp); |
There was a problem hiding this comment.
Handle invalid format error using db.js. No need of separate function.
sidekick/input-sanitization.js
Outdated
| @@ -79,6 +79,14 @@ exports.isMember = async (chatId, groupMembers) => { | |||
| } | |||
| } | |||
|
|
|||
| exports.invalidFormat = async(err, client, BotsApp) => { | |||
modules/calc.js
Outdated
| async handle(client, chat, BotsApp, args) { | ||
| let output; | ||
| try{ | ||
| output = math.evaluate(args[0]); |
There was a problem hiding this comment.
- Handle the case where the user sends multiple expressions in a single command.
- Provide a list of operations allowed.
modules/calc.js
Outdated
| name: "calc", | ||
| description: calc.DESCRIPTION, | ||
| extendedDescription: calc.EXTENDED_DESCRIPTION, | ||
| demo: { isEnabled: true, text: ".calc" }, |
There was a problem hiding this comment.
add a sample expression for demo
| demo: { isEnabled: true, text: ".calc 2^4+5!" }, | ||
| async handle(client, chat, BotsApp, args) { | ||
| let output = math.evaluate(args[0]); | ||
| if(!isNaN(output)) { |
There was a problem hiding this comment.
Having ! negates the condition, which equates to if not is not a number, then say invalid syntax. This means that if the output is a number, then say invalid syntax, which is not what we want.
| if(!isNaN(output)) { | |
| if(isNaN(output)) { |
| extendedDescription: calc.EXTENDED_DESCRIPTION, | ||
| demo: { isEnabled: true, text: ".calc 2^4+5!" }, | ||
| async handle(client, chat, BotsApp, args) { | ||
| let output = math.evaluate(args[0]); |
There was a problem hiding this comment.
You can wrap a try catch block around this function call. Thus, whenever any error happens, the error is handled there and the value of output is set to undefined. You can then handle the error in the catch block, sending a message to WA with the Error Message. Have a look -
| try { | ||
| client.sendMessage( | ||
| BotsApp.chatId, | ||
| `${args[0]} = ${output}`, |
There was a problem hiding this comment.
You can bold out the output using *, looks much better
| extendedDescription: calc.EXTENDED_DESCRIPTION, | ||
| demo: { isEnabled: true, text: ".calc 2^4+5!" }, | ||
| async handle(client, chat, BotsApp, args) { | ||
| let output = math.evaluate(args[0]); |
There was a problem hiding this comment.
Instead of restricting the user to add their expressions without any spaces (more values in the args array), it's better if we concatenate the full array in a single string before using the evaluate call.
|
Also, @IsomerX resolve the conversation threads with prashant for the issues you have resolved already. |
User just needs to type .calc (followed by any math equation)
for example:
.calc 2+2