Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not at all clear documentation. #15820

Open
HarshitaSingh-MSFT opened this issue Sep 7, 2021 · 5 comments
Open

Not at all clear documentation. #15820

HarshitaSingh-MSFT opened this issue Sep 7, 2021 · 5 comments
Labels
Doc - Reference feature-request This issue requires a new behavior in the product in order be resolved. good first issue Issues suited for folks who want to help for the first time. Network Service Attention This issue is responsible by Azure service team.

Comments

@HarshitaSingh-MSFT
Copy link

HarshitaSingh-MSFT commented Sep 7, 2021 •
edited by dingmeng-xue

Description of the new feature

Transferring this issue#1877 from azure-docs-powershell to azure-powershell repo.

FYI @dcaro and @Raag007

Proposed implementation details (optional)

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

  • ID: 2b963d11-ab7f-b257-2ec2-89e1327f1b0a
  • Version Independent ID: dc1846a2-4d0a-fd2b-ecd1-1670435e86b6
  • Content: Set-AzNetworkSecurityRuleConfig (Az.Network)
  • Content Source: src/Network/Network/help/Set-AzNetworkSecurityRuleConfig.md
  • Service: virtual-network
  • GitHub Login: @dcaro
  • Microsoft Alias: dcaro

Description: MicrosoftDocs/azure-docs-powershell#1877 (comment)
On your sandbox, when you get a chance please try to run these commands provided in this document.

$nsg = Get-AzNetworkSecurityGroup -Name "NSG-FrontEnd" -ResourceGroupName "TestRG"
$nsg | Get-AzNetworkSecurityRuleConfig -Name "rdp-rule"
Set-AzNetworkSecurityRuleConfig -Name "rdp-rule" -NetworkSecurityGroup $nsg -Access "Deny"
@HarshitaSingh-MSFT HarshitaSingh-MSFT added feature-request This issue requires a new behavior in the product in order be resolved. needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Sep 7, 2021
@dingmeng-xue dingmeng-xue added Doc - Reference Network Service Attention This issue is responsible by Azure service team. labels Sep 8, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Sep 8, 2021
@ghost
Copy link

ghost commented Sep 8, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

Issue Details

Description of the new feature

Transferring this issue#1877 from azure-docs-powershell to azure-powershell repo.

FYI @dcaro and @Raag007

Proposed implementation details (optional)

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

  • ID: 2b963d11-ab7f-b257-2ec2-89e1327f1b0a
  • Version Independent ID: dc1846a2-4d0a-fd2b-ecd1-1670435e86b6
  • Content: Set-AzNetworkSecurityRuleConfig (Az.Network)
  • Content Source: src/Network/Network/help/Set-AzNetworkSecurityRuleConfig.md
  • Service: virtual-network
  • GitHub Login: @dcaro
  • Microsoft Alias: dcaro

Description: MicrosoftDocs/azure-docs-powershell#1877 (comment)
On your sandbox, when you get a chance please try to run these commands provided in this document.

$nsg = Get-AzNetworkSecurityGroup -Name "NSG-FrontEnd" -ResourceGroupName "TestRG"
$nsg | Get-AzNetworkSecurityRuleConfig -Name "rdp-rule"
Set-AzNetworkSecurityRuleConfig -Name "rdp-rule" -NetworkSecurityGroup $nsg -Access "Deny"
Author: HarshitaSingh-MSFT
Assignees: -
Labels:

Network, feature-request, Doc - Reference, Service Attention, needs-triage
Milestone: -

@dingmeng-xue
Copy link
Member

@Raag007 , Get-AzNetworkSecurityRuleConfig tries to find rule config according to the name. It doesn't explain how security in example was created. It should have a rule named rdp-rule. If your security group doesn't contain it, the command will show error.

azure-powershell/src/Network/Network/NetworkSecurityGroup/NetworkSecurityRule/GetAzureNetworkSecurityRuleConfigCommand.cs

Line 43 in 2a56655

var rules = this.DefaultRules

@dingmeng-xue
Copy link
Member

Technically, it should fix below code and avoid to return Get-AzNetworkSecurityRuleConfig: Sequence contains no matching element

azure-powershell/src/Network/Network/NetworkSecurityGroup/NetworkSecurityRule/GetAzureNetworkSecurityRuleConfigCommand.cs

Line 50 in 2a56655

rules.First(

@dingmeng-xue dingmeng-xue added the good first issue Issues suited for folks who want to help for the first time. label Sep 8, 2021
@pmsousa
Copy link

pmsousa commented Mar 9, 2022

Get-AzNetworkSecurityRuleConfig

The behavior of outputting that message, prevents the usage of Get-AzNetworkSecurityRuleConfig on conditional clauses like:

~ (Get-AzNetworkSecurityRuleConfig -Name 'AzureBasicInfrastructure' -NetworkSecurityGroup $nsg) -eq $null
Get-AzNetworkSecurityRuleConfig: Sequence contains no matching element

@aaronpena
Copy link

Hello,
Just checking if this issue was already resolved. The documentation says the ""rdp-rule" is "user defined" which appears to explain how the security rule in the example was created. Does that satisfy this request?
2023-10-11 05_47_55-Get-AzNetworkSecurityRuleConfig (Az Network) _ Microsoft Learn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doc - Reference feature-request This issue requires a new behavior in the product in order be resolved. good first issue Issues suited for folks who want to help for the first time. Network Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pmsousa @HarshitaSingh-MSFT @aaronpena @dingmeng-xue