Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP "Lack of Service Account Key Rotation" finding raises "SYSTEM_MANAGED" keys #1085

Closed
x4v13r64 opened this issue Feb 17, 2021 · 1 comment
Closed

GCP "Lack of Service Account Key Rotation" finding raises "SYSTEM_MANAGED" keys #1085

x4v13r64 opened this issue Feb 17, 2021 · 1 comment
Assignees
@x4v13r64
Labels
bug Something isn't working component-provider-gcp Affects GCP provider good first issue
Milestone
5.12

Comments

@x4v13r64
Copy link
Collaborator

The https://github.com/nccgroup/ScoutSuite/blob/master/ScoutSuite/providers/gcp/rules/findings/iam-lack-of-service-account-key-rotation.json finding should only flag USER_MANAGED keys (https://cloud.google.com/iam/docs/reference/rest/v1/projects.serviceAccounts.keys), as SYSTEM_MANAGED keys are "managed and rotated by Google"
@x4v13r64 x4v13r64 added bug Something isn't working component-provider-gcp Affects GCP provider good first issue labels Feb 17, 2021
@x4v13r64 x4v13r64 added this to the 5.11 milestone Feb 17, 2021
@x4v13r64 x4v13r64 self-assigned this Mar 1, 2021
@alessandrogonzalez alessandrogonzalez modified the milestones: 5.11, 5.12 May 7, 2021
This was referenced Sep 17, 2021
Closed
Merged
@fernando-gallego
Copy link
Collaborator

Fixed in 5.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@x4v13r64 x4v13r64

Labels
bug Something isn't working component-provider-gcp Affects GCP provider good first issue
Projects
None yet
Milestone
5.12
3 participants
@x4v13r64 @alessandrogonzalez @fernando-gallego