Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL DB Proj - updateSystemDatabaseReferencesInProjFile doesn't handle all cases #19641

Closed
Charles-Gagnon opened this issue Jun 6, 2022 · 1 comment
Closed

SQL DB Proj - updateSystemDatabaseReferencesInProjFile doesn't handle all cases #19641

Charles-Gagnon opened this issue Jun 6, 2022 · 1 comment
Labels
Area - SQL Project Bug Good First Issue Issues that are candidates for developers to fix who may be less familiar with the codebase
Milestone
Backlog

Comments

@Charles-Gagnon
Copy link
Contributor

It currently assumes that there is only a single ItemGroup with ArtifactReference items in it and that the ItemGroup doesn't have any other items in it. There are two issues with that :

  1. If there are multiple ItemGroups with ArtifactReference items then we won't clean up until all items are removed
  2. If the ItemGroup has other non-ArtifactReference items in it then those will be deleted
@Charles-Gagnon Charles-Gagnon mentioned this issue Jun 6, 2022
Merged
@kisantia kisantia added this to the Backlog milestone Jun 6, 2022
@kisantia kisantia added Good First Issue Issues that are candidates for developers to fix who may be less familiar with the codebase and removed Triage: Needed labels Jun 6, 2022
@kisantia
Copy link
Contributor

kisantia commented Dec 8, 2022

Should be fixed by the work to move the sql project xml parsing to DacFx, which will leverage Microsoft.Build libraries to do the reading and writing to the .sqlproj

@kisantia kisantia closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - SQL Project Bug Good First Issue Issues that are candidates for developers to fix who may be less familiar with the codebase
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Charles-Gagnon @kisantia