new metrics and dimensions for sdk init #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wsbrunson
commented
Dec 8, 2023
wsbrunson
commented
- changing the gauge to actually be a gauge
- added new dimensions
- added a new init count metric and included a bunch more dimensions there too
- misc cleanup
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 72.89% 69.92% -2.98%
==========================================
Files 22 22
Lines 1797 1862 +65
Branches 217 221 +4
==========================================
- Hits 1310 1302 -8
- Misses 477 550 +73
Partials 10 10 ☔ View full report in Codecov by Sentry. |
elizabethmv
approved these changes
Dec 11, 2023
siddy2181
approved these changes
Jan 2, 2024
wsbrunson
commented
Feb 2, 2024
src/tracking.js
Outdated
| // $FlowFixMe beaver-logger types need to be updated | ||
| .metric({ | ||
| metricNamespace: "pp.app.paypal_sdk.init.gauge", | ||
| metricType: "gauge", |
There was a problem hiding this comment.
remove any gauge metrics, we don't support them in the logger server at this time
nbierdeman
force-pushed
the
better-tracking
branch
from
33ae0e9
to
4536029
Compare
nbierdeman
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.