Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freetype text source doesn't toggle text/path fields when toggling "Read from file" #5638

Closed
dxf opened this issue Dec 9, 2021 · 5 comments · Fixed by #7835
Closed

Freetype text source doesn't toggle text/path fields when toggling "Read from file" #5638

dxf opened this issue Dec 9, 2021 · 5 comments · Fixed by #7835
Labels
Confirmed This bug report has been confirmed by project members Good first issue New to contributing to OBS? Start here!

Comments

@dxf
Copy link

dxf commented Dec 9, 2021 •
edited

Operating System Info

macOS 11.6

Other OS

No response

OBS Studio Version

27.1.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/BvqNhdneGR7qcacg

OBS Studio Crash Log URL

No response

Expected Behavior

Ticking the 'Read from file' box should disable the 'Text' box, and replace it with a path to file box.

Current Behavior

The 'Text' box never disappears, and when a file location is entered into it, nothing happens

Steps to Reproduce

  1. Open OBS (Using an M1 Mac Mini)
  2. Add Text (FreeType 2)
  3. Click 'Read from file'
    Screenshot 2021-12-09 at 13 25 39
    Screenshot 2021-12-09 at 13 26 10
    Screenshot 2021-12-09 at 13 26 20
    Screenshot 2021-12-09 at 13 26 36

Anything else we should know?

Reading the log, I can see that it fails to open file '' - presumably this is because I can't populate the field that it would normally source the path from.
@dxf dxf changed the title Read from file does not enable on macOS Read from file does not enable correctly on macOS Dec 9, 2021
@asher-the-thrasher
Copy link

If you scroll down a little in the properties window, you will see a text area for the file name. That’s where you should put the file name instead of the normal text box

@dxf
Copy link
Author

dxf commented Dec 9, 2021 •
edited

If you scroll down a little in the properties window, you will see a text area for the file name. That’s where you should put the file name instead of the normal text box

Found it - thanks!

I'd suggest that this should be changed, however, to mimic the behaviour of the Windows build, where the 'Text' field is replaced with the Path field - it caught me out, for sure, because I was expecting that to occur, and didn't read the other field. (Silly me!)

@WizardCM WizardCM added the Confirmed This bug report has been confirmed by project members label Dec 20, 2021
@WizardCM WizardCM changed the title Read from file does not enable correctly on macOS Freetype text source doesn't toggle text/path fields when toggling "Read from file" Dec 20, 2021
@WizardCM WizardCM added the Good first issue New to contributing to OBS? Start here! label Dec 21, 2021
@himanshu007-creator
Copy link

Hi ! I would like to work on this issue , please guide me on what needs to be done

@gxalpha gxalpha mentioned this issue Dec 27, 2021
Closed
6 tasks
@jatinsahijwani
Copy link

i would like to work on this issue, can i?

@gxalpha gxalpha mentioned this issue Nov 22, 2022
Merged
6 tasks
@gxalpha
Copy link
Member

gxalpha commented Jan 12, 2023

As written, this is a feature request, for which we don't use GitHub Issues for tracking. As such, I will now close this issue.

Normally I would now advise you to open a formal feature request, however there is already an open Pull Request to address this (#7835), so that probably won't be needed.

@gxalpha gxalpha closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed This bug report has been confirmed by project members Good first issue New to contributing to OBS? Start here!
Projects
None yet
Milestone
No milestone
6 participants
@WizardCM @dxf @gxalpha @himanshu007-creator @asher-the-thrasher @jatinsahijwani