New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specification of id prop on ErrorMessage #2427
Comments
Let's say we have
So giving ErrorMessage an id prop will work for 1 out of 3 scenarios. |
I will try to implement this. |
The id passed to ErrorMessage need to be rendered inside the element in children |
Hi i want to take on this issue. If no one is working on it. |
Is anyone working on this ?? |
Hey , I am a beginner caan anyone help me out . |
Added an id prop to ErrorMessage [jaredpalmer#2427]
@krichter722 Can you please assign this to me? Thanks. |
@ZainGulbaz No, I can't assign users to issues. There seem to be no assignments to issues in this project. |
@krichter722 Thanks for the clarification. I will make a pull request then. |
Can I work on this? |
A property
|
馃殌 Feature request
Current Behavior
The type
ErrorMessage
doesn't have an id property.Desired Behavior
It'd be nice
id?: string
would be added to the typeErrorMessage
and set on the outermost component that serves as error message.Suggested Solution
Add
id={this.props.id}
to the outer component inErrorMessage
.Who does this impact? Who is this for?
This improves handling of error messages in e2e tests. It doesn't impact users in any way as the prop can still be omitted.
Describe alternatives you've considered
Wrapping
ErrorMessage
in adiv
which has the sole purpose of providing the id which is not nice.Additional context
./.
The text was updated successfully, but these errors were encountered: