Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nacos-client sdk remove prometheus dependency and metrics with other way. #8354

Open
xuminwlt opened this issue May 12, 2022 · 9 comments
Labels
area/Client Related to Nacos Client SDK good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@xuminwlt
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

提一个实际应用中碰到的一个小问题,nacos-client依赖了一个较低的prometheus版本,而且非可选,作为核心客户端sdk做到尽可能轻量级的依赖,或者一个Default实现,JMX等,如果需要prometheus,则由adapter或者另一个依赖完成,对sdk的依赖规范来讲,要多一次依赖去除和更新版本的引入,无法精简,期待一个精简的nacos-SDK。

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels May 13, 2022
@CherishCai
Copy link
Contributor

很久前同样遇到,0.5.0 实在太低了,也只能自己指定了更高的版本覆盖它。

@KomachiSion KomachiSion added the good first issue Good for newcomers label Jun 24, 2022
@stone-98
Copy link
Contributor

@KomachiSion Can I take a stab at solving the problem?

@stone-98
Copy link
Contributor

我了解了相关功能,引入prometheus的目的是为了给用户提供扩展的能力,但是如果用户不使用这个能力,我觉得引入prometheus的依赖是多余的,我们可以基于nacos插件的机制,默认对这些监控指标不进行处理,当用户引入相应的插件之后,基于插件的机制再对这些指标进行相应的处理。我现在可以对它进行实现吗?或者说需要一个更详细的设计文档呢?

@Lucius7boy
Copy link

i want to learn what should i do

@NooBMaster1412
Copy link

I want to learn from all of you bro,

@Lucius7boy
Copy link

Lucius7boy commented Aug 5, 2022 via email

@Tafalkamis
Copy link

I need to recover my Microsoft account and this is the email associated with it

@Tafalkamis
Copy link

I can't access my account because of this Microsoft Authenticator app

@KomachiSion
Copy link
Collaborator

我了解了相关功能,引入prometheus的目的是为了给用户提供扩展的能力,但是如果用户不使用这个能力,我觉得引入prometheus的依赖是多余的,我们可以基于nacos插件的机制,默认对这些监控指标不进行处理,当用户引入相应的插件之后,基于插件的机制再对这些指标进行相应的处理。我现在可以对它进行实现吗?或者说需要一个更详细的设计文档呢?

可以先出一个设计文档,如果设计的方案没有太大问题,就可以动手了。

@alibaba alibaba deleted a comment from taenananissa Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

8 participants
@xuminwlt @CherishCai @stone-98 @KomachiSion @Lucius7boy @NooBMaster1412 @Tafalkamis and others