Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cms-wordpress typescript example #38752

Closed
Josephenoch opened this issue Jul 18, 2022 · 4 comments · Fixed by #39250
Closed

cms-wordpress typescript example #38752

Josephenoch opened this issue Jul 18, 2022 · 4 comments · Fixed by #39250
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers TypeScript Related to types with Next.js.

Comments

@Josephenoch
Copy link

Describe the feature you'd like to request

I'd like to use a typescript version of the wordpress cms example

Describe the solution you'd like

A typescript version of the wordpress cms example should be added for ease of development.

Describe alternatives you've considered

None.
@balazsorban44 balazsorban44 added good first issue Easy to fix issues, good for newcomers examples Issue/PR related to examples TypeScript Related to types with Next.js. and removed template: story labels Jul 18, 2022
@balazsorban44
Copy link
Member

We are converting all our examples to TypeScript over time. Source code is here, if you would like to take a stab at it, otherwise, this is up for grab to anyone: https://github.com/vercel/next.js/tree/canary/examples/cms-wordpress

cc @maxproske if you are interested, I know you have converted many examples already. 💚

@isaaclvf
Copy link

Hey @balazsorban44 could you assign me this issue? I would like to help.

@Josephenoch
Copy link
Author

Hello @isaaclvf can we work on this together, I'll find a way to reach out to you.

@chaiwattsw chaiwattsw mentioned this issue Aug 2, 2022
Merged
3 tasks
@kodiakhq kodiakhq bot closed this as completed in #39250 Aug 5, 2022
kodiakhq bot pushed a commit that referenced this issue Aug 5, 2022
@chaiwattsw
Examples/cms-wordpress migrate to TypeScript (#39250)
5f483b9 
## Documentation / Examples

Not sure that I need to provide type to all of components or not?
Let me know if you want me to provide.
- [x] Closes #38752
- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
examples Issue/PR related to examples good first issue Easy to fix issues, good for newcomers TypeScript Related to types with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Examples/cms-wordpress migrate to TypeScript chaiwattsw/next.js
3 participants
@balazsorban44 @Josephenoch @isaaclvf