Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling client.logout() Exception gracefully with optional chaining #2447

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Handling client.logout() Exception gracefully with optional chaining #2447

wants to merge 14 commits into from
+4 −2

Conversation

ayushmourya
Copy link

@ayushmourya ayushmourya commented Aug 27, 2023 •
edited by alechkos

PR Details

  • Updated Client.js file logout function to handle incorrect data

Description

Added Optional Chaining to prevent code from breaking

Related Issue

closes #2442

Motivation and Context

How Has This Been Tested

  • Run the code locally to perform the same steps in issue, And no issue happend

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@ayushmourya ayushmourya mentioned this pull request Aug 27, 2023
Open
1 task
@tuyuribr

This comment was marked as outdated.

Sign in to view
@ayushmourya

This comment was marked as outdated.

Sign in to view
@Spoon-knif

This comment was marked as outdated.

Sign in to view
@ayushmourya

This comment was marked as off-topic.

Sign in to view
@Adi1231234

This comment was marked as off-topic.

Sign in to view
@Adi1231234

This comment was marked as off-topic.

Sign in to view
@alechkos alechkos requested review from shirser121 and removed request for Spoon-knif December 1, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adi1231234 Adi1231234 Adi1231234 approved these changes

@Spoon-knif Spoon-knif Spoon-knif approved these changes

@shirser121 shirser121 Awaiting requested review from shirser121

@aliyss aliyss Awaiting requested review from aliyss

@tuyuribr tuyuribr Awaiting requested review from tuyuribr

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client.logout() Exception
6 participants
@ayushmourya @tuyuribr @Spoon-knif @Adi1231234 @shirser121 @alechkos