fix: location options adjustments #2597
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
PR adjusts the values of the locations object to suit its primary typing.
The Location class constructor now exports the three keys in the options object:
These adjustments are to be fair and faithful to the location typing, modified by @alechkos in PR #2339.
Related Issue
Motivation and Context
I updated the lib and when I ran the build, I saw that ts issued an error due to the new typing of the options key. I adjusted the code based on the new typing, but I was surprised to learn that the new typing did not represent the real value obtained in the location key. So I decided to fix it.
How Has This Been Tested
Types of changes
Checklist