Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location options adjustments #2597

Conversation

viniciusjosedev
Copy link

PR Details

Description

PR adjusts the values ​​of the locations object to suit its primary typing.

The Location class constructor now exports the three keys in the options object:

  1. Latitude
  2. Longitude
  3. options
    1. address
    2. name
    3. url

These adjustments are to be fair and faithful to the location typing, modified by @alechkos in PR #2339.

Related Issue

Motivation and Context

I updated the lib and when I ran the build, I saw that ts issued an error due to the new typing of the options key. I adjusted the code based on the new typing, but I was surprised to learn that the new typing did not represent the real value obtained in the location key. So I decided to fix it.

How Has This Been Tested

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@viniciusjosedev viniciusjosedev marked this pull request as draft October 24, 2023 03:51
@viniciusjosedev viniciusjosedev marked this pull request as ready for review October 24, 2023 03:53
@alechkos alechkos closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants