Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement branch coverage support for exit status modifiers #844

Open
3 tasks
PragTob opened this issue Jan 28, 2020 · 2 comments
Open
3 tasks

Implement branch coverage support for exit status modifiers #844

PragTob opened this issue Jan 28, 2020 · 2 comments
Labels
Branch Coverage Feature good first issue Good first issue to pick up if you wanna go and contribute!

Comments

@PragTob
Copy link
Collaborator

PragTob commented Jan 28, 2020

Much like we can do:

SimpleCov.minimum_coverage line: 90, branch: 80

the same should be possible for:

  • minimum_coverage_by_file
  • maximum_coverage_drop
  • refuse_coverage_drop

They should all still default to line coverage (until #843 is implemented)
@PragTob PragTob mentioned this issue Jan 28, 2020
Open
@PragTob PragTob added Branch Coverage good first issue Good first issue to pick up if you wanna go and contribute! labels Aug 16, 2020
@jemmaissroff jemmaissroff mentioned this issue Oct 7, 2020
Merged
@fede-moya
Copy link
Contributor

Seems like this one has been resolved by #934

@rishijain
Copy link

can we close this issue since it is already resolved by #934 ? @PragTob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Branch Coverage Feature good first issue Good first issue to pick up if you wanna go and contribute!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PragTob @rishijain @fede-moya