Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: --all flag missing from completions for asdf latest command #1206

Closed
acidghost opened this issue Apr 18, 2022 · 1 comment · Fixed by #1319
Closed

chore: --all flag missing from completions for asdf latest command #1206

acidghost opened this issue Apr 18, 2022 · 1 comment · Fixed by #1319
Labels
good first issue help wanted

Comments

@acidghost
Copy link
Contributor

Describe the Bug

The completions for the --all flag to the latest command are missing.

Steps to Reproduce

Type asdf latest and press .

Expected Behaviour

Show --all flag besides installed plugins.

Actual Behaviour

Only shows plugins.

Environment

SHELL:
zsh 5.8 (x86_64-apple-darwin21.0)

ASDF VERSION:
v0.10.0

ASDF ENVIRONMENT VARIABLES:
ASDF_DIR=/Users/acidghost/.dotfiles/asdf-vm

ASDF INSTALLED PLUGINS:
golang                       https://github.com/kennyp/asdf-golang.git master cc8bc47
julia                        https://github.com/rkyleg/asdf-julia.git master 1788f0f
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git master f9957f3
perl                         https://github.com/ouest/asdf-perl.git master 1d6d39c
python                       https://github.com/danhper/asdf-python.git master 57a4d72
ruby                         https://github.com/asdf-vm/asdf-ruby.git master 3179071

asdf plugins affected (if relevant)

No response
@acidghost acidghost added the bug label Apr 18, 2022
@jthegedus jthegedus changed the title bug: --all missing from completions for latest command chore: --all flag missing from completions for asdf latest command Jul 17, 2022
@jthegedus
Copy link
Contributor

I changed this from a bug as completions are opt-in and not critical to the execution of the core tool. Completions are something we rely on the community to contribute updates to.

I do not use completions or know the state of what is up to date or not. Looking at the fish completions it appears we would need to add

complete -f -c asdf -n '__fish_asdf_using_command latest; and __fish_asdf_arg_number 2' -a --all'

below the following line

asdf/completions/asdf.fish

Line 103 in e1fd8ad

complete -f -c asdf -n '__fish_asdf_using_command latest; and __fish_asdf_arg_number 2' -a '(__fish_asdf_plugin_list)'

Not sure about other completions though, PRs weclome!

@hyperupcall hyperupcall mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add --all completion to asdf latest fox-forks/asdf
2 participants
@acidghost @jthegedus