Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO Fix badge links in readme #1376

Open
tablatronix opened this issue Mar 26, 2022 · 8 comments
Open

TODO Fix badge links in readme #1376

tablatronix opened this issue Mar 26, 2022 · 8 comments
Labels
Documentation Flagged for docs Good First Issue PR for newbs

Comments

@tablatronix
Copy link
Collaborator

Badges should link to pages
@tablatronix tablatronix added Documentation Flagged for docs Good First Issue PR for newbs labels Mar 26, 2022
@JoergAJ JoergAJ mentioned this issue Jun 16, 2022
Merged
@tablatronix
Copy link
Collaborator Author

tablatronix commented Jun 16, 2022 •
edited

C7ABC491-52D5-4545-86E7-6A1B3FECBA26

The ci test
link to the images and not actual pages

@JoergAJ
Copy link
Contributor

JoergAJ commented Jun 24, 2022

Links to pages at espressif like https://www.espressif.com/en/products/socs/esp32-c3 for the esp32c3 ?

@tablatronix
Copy link
Collaborator Author

Yeah but mostly the CI test status pages, but it would be cool if they are linked to some reference maybe?

@seanhagen
Copy link

@tablatronix like this: https://github.com/seanhagen/WiFiManager/tree/1376-fix-badge-links-in-readme ? I put all the badges on one line, added a link to the releases page for the "Release" badge, and put the chat & discord badges on the same line. All the other badges already have links that seem to go to the right places, but I'm not 100% sure

@tablatronix
Copy link
Collaborator Author

Looks bad on mobile

@aumpatel2624
Copy link

hey I want to contribute in solving this issue.

@tablatronix
Copy link
Collaborator Author

Do it

@tablatronix
Copy link
Collaborator Author

And feel free to add anything else to the readme or wiki it needs all the new updated stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Flagged for docs Good First Issue PR for newbs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanhagen @tablatronix @JoergAJ @aumpatel2624