[IST-460] Helpful Doc Improvements and Moment Update #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twistedpair
commented
Jul 19, 2022
twistedpair
commented
- Update moment to address CVE-2022-31129
- Add helpful doc pointers to the proper API key type to use
- Add helpful error messages when the wrong API key type is used
- Provide more helpful humanization of errors
simonychoy
approved these changes
Jul 19, 2022
| @@ -6,7 +6,7 @@ jobs: | |||
| name: Mabl Test | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@main | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Are we opting to pin all actions to a specific version in general (i.e. across other repos as well)?
There was a problem hiding this comment.
Good question. The value here of pinning to a floating version tag is that we don't need to worry about pulling in an inadvertent breaking major version.
In this case specifically, I'm pinning to the same version we're documenting as our official example of using this action (and we test this action in this workflow).
Co-authored-by: Simon Choy <46035684+simonychoy@users.noreply.github.com>
twistedpair
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.