Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): support non-text links as external #233

Merged
merged 2 commits into from Aug 2, 2022
Merged

feat(router): support non-text links as external #233

merged 2 commits into from Aug 2, 2022

Conversation

QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Aug 2, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Closes #223

Add support for non-text links to be treated as external and reload the page instead of mutating the DOM (window.location.href = ...).

request() now returns a Promise<string, Blob> since the fetched content can be an image, a file... Also, add a property external to signify that a Route redirects to an URL.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@QuiiBz QuiiBz self-assigned this Aug 2, 2022
@QuiiBz QuiiBz added the enhancement New feature or request label Aug 2, 2022
@QuiiBz QuiiBz force-pushed the feat/router-non-text-links branch from 127ca90 to b94c25f Compare August 2, 2022 07:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2780428845

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.98%
Totals Coverage Status
Change from base Build 2779883578: 0.0%
Covered Lines: 1379
Relevant Lines: 2349
💛 - Coveralls

@QuiiBz QuiiBz marked this pull request as ready for review August 2, 2022 14:47
@QuiiBz QuiiBz requested a review from aidenybai August 2, 2022 14:47
@aidenybai
Copy link
Owner

This is really well written. LGTM and thanks for the help

@aidenybai aidenybai merged commit c115c77 into main Aug 2, 2022
@QuiiBz QuiiBz deleted the feat/router-non-text-links branch August 2, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidenybai aidenybai Awaiting requested review from aidenybai

Assignees

@QuiiBz QuiiBz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: router doesn't support non text types
3 participants
@QuiiBz @coveralls @aidenybai