Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC1101 setSpi call if SPI pins are set #1665

Closed
Mirdinus opened this issue Jun 6, 2023 · 7 comments
Closed

CC1101 setSpi call if SPI pins are set #1665

Mirdinus opened this issue Jun 6, 2023 · 7 comments
Labels
stale

Comments

@Mirdinus
Copy link

Mirdinus commented Jun 6, 2023

Hi All

Is your feature request related to a problem? Please describe.
I'm using M5 Stamp-C3 (ESP32-C3) and cannot use the default pins configuration as some of the pins are not available on my board
Pinout

Describe the solution you'd like
Add ELECHOUSE_cc1101.setSPI(SCK, MISO, MOSI, CS); call just above ELECHOUSE_cc1101.Init(); if SPI pins are set to non-default
All mentions

Describe alternatives you've considered
Only other solution is not using boards with limited pinout

Additional context
I tested it with the library and It works fine. I plan to make a PR with the changes
@Mirdinus
Copy link
Author

Mirdinus commented Jun 6, 2023

Might be related ti this part of environments configuration

;  '-DRF_MODULE_MOSI=23'
;  '-DRF_MODULE_MISO=19'
;  '-DRF_MODULE_SCK=18'

@efuturetoday
Copy link

+1 it is mandatory to support WT32-ETH01 as the SPI default pinout can not be used.

@Mirdinus
Copy link
Author

You can already 'fix' it for yourself by inserting

ELECHOUSE_cc1101.setSpiPin(RF_MODULE_SCK, RF_MODULE_MISO, RF_MODULE_MOSI, RF_MODULE_CS);

above any ELECHOUSE_cc1101.Init(); call

@efuturetoday
Copy link

Thank you - I already solved it this way. I will create a PR to introduce a new board and this change, so others can just use the defines to configure the SPI interface.

@efuturetoday efuturetoday mentioned this issue Jul 20, 2023
Closed
3 tasks
@efuturetoday
Copy link

PR can be merged

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add custom SPI config for CC1101 + added board efuturetoday/OpenMQTTGateway
2 participants
@Mirdinus @efuturetoday