Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTest converted TypeScript ABI #28
Comments
This comment has been minimized.
This comment has been minimized.
|
@arun1595 -- Would you be interested in helping us tackle this? |
This comment has been minimized.
This comment has been minimized.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.15 ETH (64.11 USD @ $427.41/ETH) attached to it.
|
This comment has been minimized.
This comment has been minimized.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 7 months, 3 weeks ago. 1) arku has been approved to start work. This is pretty straightforward. I'll use the existing tests for reference to get it done. Learn more on the Gitcoin Issue Details page. |
This comment has been minimized.
This comment has been minimized.
|
@kkhurana696 -- This issue has been reserved for @arun1595. So he'll be going ahead with tackling this one. Nevertheless, we have whole bunch of other issues that we need help with. So why don't you jump in to our Discord channel and say hi over there. Thanks for your interest in MARKET Protocol :) |
This comment has been minimized.
This comment has been minimized.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.15 ETH (65.36 USD @ $435.74/ETH) has been submitted by: @pelsasser please take a look at the submitted work:
|
This comment has been minimized.
This comment has been minimized.
|
@arun1595 -- Thanks for the quick turn around on this one. I'll let @pelsasser pay this one out :) |
This comment has been minimized.
This comment has been minimized.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.15 ETH (65.53 USD @ $436.88/ETH) attached to this issue has been approved & issued to @arun1595.
|
Before you
start workPlease read our contribution guidelines and if there is a bounty involved please also see here
If you have ongoing work from other bounties with us where funding has not been released, please do not pick up a new issue. We would like to involve as many contributors as possible and parallelize the work flow as much as possible.
Please make sure to comment in the issue here immediately after starting work so we know your plans for implementation and a timeline.
Please also note that in order for work to be accepted, all code must be accompanied by test cases as well.
User Story
As a developer, I need to ensure the MARKET API TypeScript ABIs work correctly so that I can correctly interface with the MARKET contracts.
Why Is this Needed?
Summary: We need to have automated test coverage for all TypeScript ABIs. This started as part of https://github.com/MARKETProtocol/MARKET.js/issues/14. Due to the size and scope of the testing, we created a new project and repo for the MARKET.js types.
Description
Type: Enhancement
Current Behavior
There is minimal test coverage.
Expected Behavior
We need 100% test coverage on the TypeScript ABIs.
Solution
Summary:
Typechain is being used to generate types and the ABIs from which to generate the types is specified as a glob pattern in the package.json under config.typechain.include which is currently set to: Market*|CollateralToken|OraclizeQueryTest|ERC20|OrderLib
Reference the work done in issue #2.
Definition of Done