Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User friendly manual network configuration #1715

Merged
merged 4 commits into from Aug 5, 2023

Conversation

vi7
Copy link
Contributor

@vi7 vi7 commented Jul 15, 2023

Description:

  1. Add ability for user friendly IP address override without the need to touch User_config.h
  2. Add DNS server option for ESP WiFi STA

NOTE: Tested on Wemos D1 mini (ESP8266) ONLY, unfortunately I do not have a possibility to test on Arduino and ESP32

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH
Copy link
Collaborator

DigiH commented Jul 22, 2023

Testing on ESP32s and ESP8266s, including Avatto S06 IR and Sonoff RF Bridge - running smoothly.

@DigiH
Copy link
Collaborator

DigiH commented Jul 22, 2023

@vi7

Could you also add a paragraph about this in the documentation? I think it would fit nicely as a separate NOTE after the NOTE

::: warning Note Adding manual WiFi and MQTT credentials …

in

https://github.com/1technophile/OpenMQTTGateway/blob/development/docs/upload/builds.md

Thanks

@1technophile
Copy link
Owner

Also adding the macros into the following environment: [env:esp32dev-all-test]
So that they get tested

@vi7
Copy link
Contributor Author

vi7 commented Jul 27, 2023

@DigiH @1technophile thanks guys for checking this, docs updated as well.

@DigiH
Copy link
Collaborator

DigiH commented Jul 27, 2023

@vi7

Thanks for the Docs update. Could you also add the network build_flags to the [env:esp32dev-all-test] environment, as @1technophile mentioned? This assures constant tests runs with these flags, to avoid future possible regressions.

https://github.com/1technophile/OpenMQTTGateway/blob/development/environments.ini#L51

Thanks

@vi7
Copy link
Contributor Author

vi7 commented Aug 5, 2023

@DigiH done, pls let me know if network parameters (IP, mask etc.) for the test env should be different

Not caused by you @vi7, I just spotted this next environment not having an empty line before. Small clean up.
@1technophile
Copy link
Owner

Thanks!

@1technophile 1technophile merged commit 2aa4368 into 1technophile:development Aug 5, 2023
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants