FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
83 27 0 0

ca.uhn.hl7v2.hoh.encoder.AbstractHl7OverHttpDecoder

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.hoh.encoder.AbstractHl7OverHttpDecoder.readBytesChunked(InputStream): new String(byte[], int, int) I18N DM_DEFAULT_ENCODING 288 High

ca.uhn.hl7v2.hoh.encoder.ResponseCode

Bug Category Details Line Priority
ca.uhn.hl7v2.hoh.encoder.ResponseCode.setCode(int) unconditionally sets the field myCode BAD_PRACTICE ME_ENUM_FIELD_SETTER 114 Medium
ca.uhn.hl7v2.hoh.encoder.ResponseCode.setMessage(String) unconditionally sets the field myMessage BAD_PRACTICE ME_ENUM_FIELD_SETTER 129 Medium
Load of known null value in ca.uhn.hl7v2.hoh.encoder.ResponseCode.forAcknowledgementCode(String) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 57 Medium

ca.uhn.hl7v2.hoh.hapi.server.HohServlet

Bug Category Details Line Priority
Class ca.uhn.hl7v2.hoh.hapi.server.HohServlet defines non-transient non-serializable instance field myApplicationRouter BAD_PRACTICE SE_BAD_FIELD Not available Medium
ca.uhn.hl7v2.protocol.impl.ApplicationRouterImpl stored into non-transient field HohServlet.myApplicationRouter BAD_PRACTICE SE_BAD_FIELD_STORE 41 Medium

ca.uhn.hl7v2.hoh.raw.client.HohRawClientMultithreaded

Bug Category Details Line Priority
Inconsistent synchronization of ca.uhn.hl7v2.hoh.raw.client.HohRawClientMultithreaded.mySocketTimeout; locked 66% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 220 Medium
ca.uhn.hl7v2.hoh.raw.client.HohRawClientMultithreaded.getSocketTimeout() is unsynchronized, ca.uhn.hl7v2.hoh.raw.client.HohRawClientMultithreaded.setSocketTimeout(long) is synchronized MT_CORRECTNESS UG_SYNC_SET_UNSYNC_GET 202 Medium

ca.uhn.hl7v2.hoh.raw.client.HohRawClientMultithreaded$TimeoutTask

Bug Category Details Line Priority

ca.uhn.hl7v2.hoh.raw.client.HohRawClientSimple

Bug Category Details Line Priority
ca.uhn.hl7v2.hoh.api.MessageMetadataKeys is incompatible with expected argument type String in ca.uhn.hl7v2.hoh.raw.client.HohRawClientSimple.main(String[]) CORRECTNESS GC_UNRELATED_TYPES 153 High

ca.uhn.hl7v2.hoh.raw.server.HohRawServlet

Bug Category Details Line Priority
Class ca.uhn.hl7v2.hoh.raw.server.HohRawServlet defines non-transient non-serializable instance field myAuthorizationCallback BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class ca.uhn.hl7v2.hoh.raw.server.HohRawServlet defines non-transient non-serializable instance field myMessageHandler BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class ca.uhn.hl7v2.hoh.raw.server.HohRawServlet defines non-transient non-serializable instance field mySigner BAD_PRACTICE SE_BAD_FIELD Not available Medium

ca.uhn.hl7v2.hoh.sockets.CustomCertificateTlsSocketFactory

Bug Category Details Line Priority
ca.uhn.hl7v2.hoh.sockets.CustomCertificateTlsSocketFactory.initialize() may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 106 Medium
ca.uhn.hl7v2.hoh.sockets.CustomCertificateTlsSocketFactory.initialize() may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 106 Medium

ca.uhn.hl7v2.hoh.util.IOUtils

Bug Category Details Line Priority
Possible null pointer dereference in ca.uhn.hl7v2.hoh.util.IOUtils.deleteAllFromDirectory(File) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 70 Medium
Possible null pointer dereference in ca.uhn.hl7v2.hoh.util.IOUtils.deleteAllFromDirectoryExcept(File, List) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 82 Medium
Exceptional return value of java.io.File.delete() ignored in ca.uhn.hl7v2.hoh.util.IOUtils.deleteAllFromDirectory(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 76 Medium
Exceptional return value of java.io.File.delete() ignored in ca.uhn.hl7v2.hoh.util.IOUtils.deleteAllFromDirectoryExcept(File, List) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 96 Medium

ca.uhn.hl7v2.hoh.util.KeystoreUtils

Bug Category Details Line Priority
ca.uhn.hl7v2.hoh.util.KeystoreUtils.loadKeystore(File, char[]) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 28 Medium

ca.uhn.hl7v2.hoh.util.VersionLogger

Bug Category Details Line Priority
ca.uhn.hl7v2.hoh.util.VersionLogger.init() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 44 Medium
ca.uhn.hl7v2.hoh.util.VersionLogger.init() may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 38 Medium

ca.uhn.hl7v2.hoh.util.repackage.Base64

Bug Category Details Line Priority
Found reliance on default encoding in ca.uhn.hl7v2.hoh.util.repackage.Base64.main(String[]): String.getBytes() I18N DM_DEFAULT_ENCODING 64 High
Switch statement found in ca.uhn.hl7v2.hoh.util.repackage.Base64.decode(byte[], int, int, Base64$Context) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 494-506 Medium
Switch statement found in ca.uhn.hl7v2.hoh.util.repackage.Base64.encode(byte[], int, int, Base64$Context) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 368-388 Medium
Unread field: ca.uhn.hl7v2.hoh.util.repackage.Base64.PAD; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 936 Medium

ca.uhn.hl7v2.hoh.util.repackage.Base64$CharEncoding

Bug Category Details Line Priority
Should ca.uhn.hl7v2.hoh.util.repackage.Base64$CharEncoding be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1350 Medium

ca.uhn.hl7v2.hoh.util.repackage.Base64$Context

Bug Category Details Line Priority
Unused field: ca.uhn.hl7v2.hoh.util.repackage.Base64$Context.lbitWorkArea PERFORMANCE UUF_UNUSED_FIELD Not available Medium